Handle peer permission updates in PeerDiscoveryAgentV5#10193
Merged
usmansaleem merged 4 commits intobesu-eth:mainfrom Apr 15, 2026
Merged
Conversation
Signed-off-by: Matilda Clerke <[email protected]>
Signed-off-by: Matilda Clerke <[email protected]>
usmansaleem
reviewed
Apr 15, 2026
...p/src/main/java/org/hyperledger/besu/ethereum/p2p/discovery/discv5/PeerDiscoveryAgentV5.java
Outdated
Show resolved
Hide resolved
usmansaleem
reviewed
Apr 15, 2026
...p/src/main/java/org/hyperledger/besu/ethereum/p2p/discovery/discv5/PeerDiscoveryAgentV5.java
Outdated
Show resolved
Hide resolved
usmansaleem
reviewed
Apr 15, 2026
...p/src/main/java/org/hyperledger/besu/ethereum/p2p/discovery/discv5/PeerDiscoveryAgentV5.java
Outdated
Show resolved
Hide resolved
usmansaleem
requested changes
Apr 15, 2026
Contributor
usmansaleem
left a comment
usmansaleem
left a comment
There was a problem hiding this comment.
Instead of isPeerNotPermitted, refactor and use isPeerPermitted.
Signed-off-by: Matilda Clerke <[email protected]>
daniellehrner
added a commit
that referenced
this pull request
Apr 15, 2026
* Add SHL, SHR and SAR shift operations for EVM v2 (#10154) * Add SHL, SHR and SAR implementations and benchmarks for EVM v2 Signed-off-by: Ameziane H. <[email protected]> * Upgrade RocksDB version from 9.7.3 to 10.6.2 (#9767) * Upgrade RocksDB version from 9.7.3 to 10.6.2 * Fix JNI SIGSEGV crashes Signed-off-by: Ameziane H. <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> * Add missing verification metadata (#10198) Signed-off-by: Fabio Di Fabio <[email protected]> * Stream debug_traceBlock* responses directly to avoid OOM on large blocks (#9848) * stream block traces on op code level Signed-off-by: daniellehrner <[email protected]> * correctly parse default setting for memory tracing Signed-off-by: daniellehrner <[email protected]> * fix initcode capture for failed create op codes Signed-off-by: daniellehrner <[email protected]> * created separate streaming debug tracer, for batch request fall back to accumulation in memory, adddress pr comments Signed-off-by: daniellehrner <[email protected]> * execute tests from genesis and verify full trace Signed-off-by: daniellehrner <[email protected]> * addressed pr comments Signed-off-by: daniellehrner <[email protected]> * spotless Signed-off-by: daniellehrner <[email protected]> * optimize trace streaming and struct log handling Signed-off-by: Ameziane H. <[email protected]> * spotless Signed-off-by: Ameziane H. <[email protected]> * Fix remaining issues and add unit tests Signed-off-by: Ameziane H. <[email protected]> * added back pressure when writing to the socket and reduced the buffer size to work better with netty's default buffer size Signed-off-by: daniellehrner <[email protected]> * improve error handling by deferring to send the header only when data is available, allows to send the proper error codes during setup Signed-off-by: daniellehrner <[email protected]> * compactHex candidate comparison Signed-off-by: daniellehrner <[email protected]> * wire in more performant hex writer Signed-off-by: daniellehrner <[email protected]> * introduce separate timeout for streaming calls, defaults to 10 minutes Signed-off-by: daniellehrner <[email protected]> * spotless Signed-off-by: daniellehrner <[email protected]> * Fix streamin/accumulating output parity, added missing refund field, corrected error format, reason encoding, returnValue prefix, and precompile gasCost, with equivalence tests between both Signed-off-by: daniellehrner <[email protected]> * revert accidental removal of 0x prefix Signed-off-by: daniellehrner <[email protected]> * pad memory bytes to 32 bytes Signed-off-by: daniellehrner <[email protected]> --------- Signed-off-by: daniellehrner <[email protected]> Signed-off-by: Ameziane H. <[email protected]> Co-authored-by: Ameziane H. <[email protected]> * Optimize performance and reduce memory when creating Quantity from scalar (#10134) * Optimize performance and reduce memory when creating Quantity from scalar Signed-off-by: Fabio Di Fabio <[email protected]> * Benchmark other implementations Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> * snap sync - apply BALs before flat db heal (#10151) Signed-off-by: Miroslav Kovar <[email protected]> * Remove dryRunDetector workaround methods from unit tests (#10201) * Remove dryRunDetector workaround methods from unit tests The dryRunDetector methods were added as a workaround for a Gradle issue that prevented @ParameterizedTest classes from being selected when running with --dry-run. Since the issue is fixed and --dry-run is no longer used, these methods are no longer needed. Signed-off-by: Fabio Di Fabio <[email protected]> * Remove dryRunDetector workaround from acceptance tests too The Gradle issue is confirmed fixed, so the workaround is no longer needed anywhere, including acceptance tests. Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> * preserve state gas reservoir for the top level frame in case of OOG (#10205) Signed-off-by: daniellehrner <[email protected]> * Enable execution processor on PoA networks with system contract addresses (#10196) * enable the prague execution processor for poa networks that have the systems contract addresses set in their genesis file Signed-off-by: daniellehrner <[email protected]> * Fix engine_getPayloadV1 to return -38001 instead of -32001 for unknown payloadId (#10179) The Engine API spec requires error code -38001 (Unknown payload) when engine_getPayloadV1 is called with an unrecognized payloadId. Besu was incorrectly returning -32001 (Resource not found), which is a non-standard error code that may cause interoperability issues with consensus layer clients. Fixes #10174 Signed-off-by: Vivek Singh Solanki <[email protected]> * Exclude IntelliJ bin/default output from Spotless shell script check (#10210) When IntelliJ syncs a Gradle project without build delegation, it copies processed resources (including reference test shell scripts from the submodule) into bin/default/. Spotless then finds these copies and incorrectly flags them for missing license headers, while CI never sees bin/default/ since it runs bare Gradle. Add '**/bin/default/**' to the ShellScripts targetExclude, matching the existing pattern used for other generated/external content. Signed-off-by: Simon Dudley <[email protected]> Co-authored-by: Claude Sonnet 4.6 <[email protected]> * Missing memory presence check (#10213) * Call lastFrame.getMemory().isPresent() before calling lastFrame.getMemory().get().length to avoid NPE Signed-off-by: daniellehrner <[email protected]> Co-authored-by: Copilot <[email protected]> * feat: add transactionReceipts subscription support in eth_subscribe #… (#10190) Signed-off-by: Vivek Singh Solanki <[email protected]> * remove 2nd definition of forceCaptureMem Signed-off-by: daniellehrner <[email protected]> * Exclude IntelliJ generated dir from spotless solidity (#10223) Signed-off-by: Simon Dudley <[email protected]> * ci check to make sure that all libraries have their source code verified as well (#10217) Signed-off-by: daniellehrner <[email protected]> * Implement aggregation in pipeline service (#10202) Signed-off-by: Miroslav Kovar <[email protected]> * Add enableMemory parameter to debug_traceTransaction and debug_traceBlockByNumber (#10169) * Add enableMemory parameter to debug_traceTransaction Adds the enableMemory param (default false) to TransactionTraceParams. When both enableMemory and disableMemory are provided, enableMemory takes precedence. Ref: #10115 Signed-off-by: Vivek Singh Solanki <[email protected]> * Update CHANGELOG for enableMemory parameter Signed-off-by: Vivek Singh Solanki <[email protected]> --------- Signed-off-by: Vivek Singh Solanki <[email protected]> * Exclude halt-burned gas from block regular gas (#10225) * Exclude halt-burned gas from block regular gas Signed-off-by: daniellehrner <[email protected]> * Add contributor call agenda issue template (#10232) * Add contributor call agenda issue template --------- Signed-off-by: jflo <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Co-authored-by: Claude Opus 4.6 (1M context) <[email protected]> Co-authored-by: Copilot <[email protected]> * Improve block proposal cancellation to (best effort) avoid concurrency issues (#10219) * Fix concurrency issues when block proposal is cancelled during tx selection When block creation is cancelled or times out, the selection thread may still be running briefly. This change adds a CountDownLatch to internal tx selection (mirroring the existing plugin selection mechanism) and extracts a shared waitForCancellationToBeProcessed method that correctly handles negative remaining-time values and logs the outcome of the wait. Exception handling in both selection phases is split by type so that rollback() is only called for ExecutionException, where the selection thread is guaranteed to have finished. CancellationException and InterruptedException no longer trigger a rollback, removing a potential race on shared world state. In MergeCoordinator, exceptions thrown after a cancellation are now logged at INFO with guidance to report if unexpected, rather than at WARN, reducing noise from the expected concurrency edge cases during block proposal cancellation. Signed-off-by: Fabio Di Fabio <[email protected]> * Add unit tests for concurrency fixes and repair early-return regression - Add test verifying CancellationException during plugin selection is handled gracefully (no exception propagated to caller) - Add test verifying internal selection CountDownLatch causes buildTransactionListForBlock() to wait for the selection thread - Add test verifying Throwable thrown after block creation cancellation is handled gracefully (logged at INFO, not propagated) - Remove early return from timeLimitedSelection when isCancelled is true: the guard was causing validPendingTransactionIsNotIncludedIf SelectionCancelled to fail because evaluatePendingTransaction (which marks each tx as SELECTION_CANCELLED) was never reached; the check is unnecessary since evaluatePendingTransaction already handles isCancelled on every iteration without touching world state Signed-off-by: Fabio Di Fabio <[email protected]> --------- Signed-off-by: Fabio Di Fabio <[email protected]> * Feature add block import trace to eth simulate (#10211) * initial addition of optional block import tracing to eth_simulateV1 * move block traceEnd prior to trielog write --------- Signed-off-by: garyschulte <[email protected]> Co-authored-by: Justin Florentine <[email protected]> * Handle peer permission updates in PeerDiscoveryAgentV5 (#10193) * Handle peer permission updates in PeerDiscoveryAgentV5 * Remove apparently unneeded mock calls * Refactor to reduce code deduplication --------- Signed-off-by: Matilda Clerke <[email protected]> --------- Signed-off-by: Ameziane H. <[email protected]> Signed-off-by: Fabio Di Fabio <[email protected]> Signed-off-by: daniellehrner <[email protected]> Signed-off-by: Miroslav Kovar <[email protected]> Signed-off-by: Vivek Singh Solanki <[email protected]> Signed-off-by: Simon Dudley <[email protected]> Signed-off-by: jflo <[email protected]> Signed-off-by: Justin Florentine <[email protected]> Signed-off-by: garyschulte <[email protected]> Signed-off-by: Matilda Clerke <[email protected]> Co-authored-by: ahamlat <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Co-authored-by: Fabio Di Fabio <[email protected]> Co-authored-by: Miroslav Kovář <[email protected]> Co-authored-by: Vivek Singh Solanki <[email protected]> Co-authored-by: Simon Dudley <[email protected]> Co-authored-by: Claude Sonnet 4.6 <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Justin Florentine <[email protected]> Co-authored-by: garyschulte <[email protected]> Co-authored-by: Matilda-Clerke <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
Handle peer permission updates in PeerDiscoveryAgentV5
Fixed Issue(s)
#10101